Bump LibreOffice library odfdom-java to 0.12.0, require JDK 11+ for generating Calc file ODS by slawekjaranowski · Pull Request #684 · mojohaus/license-maven-plugin (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the odfdom-java library from version 0.9.0 to 0.12.0 to address security vulnerabilities in the older version. The upgrade requires JDK 11+ for generating LibreOffice Calc (ODS) files, implemented using a Multi-Release JAR (MRJAR) pattern to maintain backward compatibility with JDK 8.
Key changes:
- Upgraded odfdom-java dependency to 0.12.0 and added xml-apis 1.4.01 for JDK 8 compatibility
- Implemented MRJAR pattern with JDK 8 stub throwing UnsupportedOperationException and full JDK 11+ implementation
- Added JDK version check in tests and integration test requirements
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated odfdom-java to 0.12.0, added xml-apis dependency, configured MRJAR profile with compiler and surefire plugins |
| src/main/java/org/codehaus/mojo/license/extended/spreadsheet/CalcFileWriter.java | JDK 8 stub implementation throwing UnsupportedOperationException |
| src/main/java11/org/codehaus/mojo/license/extended/spreadsheet/CalcFileWriter.java | Complete JDK 11+ implementation for ODS file generation |
| src/test/java/org/codehaus/mojo/license/download/LicenseSummaryTest.java | Added version check to conditionally test ODS generation or exception handling |
| src/main/java/org/codehaus/mojo/license/utils/MojoHelper.java | Fixed URL concatenation to prevent double slashes when baseUrl already ends with "/" |
| src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java | Added documentation noting JDK 11+ requirement for ODS file generation |
| src/it/aggregate-download-licenses-extended-spreadsheet/invoker.properties | Set minimum JDK version to 11+ for integration test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.