Add internal API to create AppVersions by diox · Pull Request #15198 · mozilla/addons-server (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name suggests that this is a test for when the star version already exists, but you don't seem to include the setup code that pre-creates the star version.

This also suggests that there may not be sufficient assertions in these tests if it's critical to know that only the non-pre-created versions have been created, which is why this test currently passes. Having said that, I'm not sure it's terribly important to know that.