[InputBase] Fix autofill issue by mnajdova · Pull Request #28070 · mui/material-ui (original) (raw)

Seems like this is a footgun for GlobalStyles in general with styled-components.

Not sure what we can do about this.. :\

We should document this for GlobalStyles. Have you checked the other uses of GlobalStyles in the codebase?

This and the CSSBaseline are the only components that use GlobalStyles. With the CSSBaseline it should not be a big problem I think, but in the InputBase is more obvious, as it is used much more, and it is more dynamic...

About the documentation, agree, I will create a PR with a note in the documentation for the GlobalStyles used with styled-components.

Do both issues require this complete change or did you group two changes that can independently fix either issue?

I've grouped the two changes, mostly because they are both affected by the global styles and they are both part of the v5 milestone.