[grid] Remove 'column' and 'column-reverse' options from GridDirection type by sai6855 · Pull Request #47564 · mui/material-ui (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GridDirection type is being updated to remove 'column' and 'column-reverse' values, but this change is incomplete. Several other parts of the codebase still reference these values and need to be updated:

  1. PropTypes validation (lines 181-182 in this file) still accepts 'column' and 'column-reverse'
  2. The DIRECTIONS constant in gridClasses.ts (line 18) still includes all four values
  3. The underlying @mui/system/Grid/GridProps.ts still defines GridDirection with all four values
  4. PigmentGrid also has the full set of direction values

This incomplete change will cause inconsistencies between TypeScript type checking and runtime behavior, and may break applications that use column directions. Consider either completing all related changes together or reverting this change until a comprehensive update can be made.

export type GridDirection = 'row' | 'row-reverse';
export type GridDirection = 'row' | 'row-reverse' 'column' 'column-reverse';