[circularprogress] Remove deprecated classes by silviuaavram · Pull Request #48014 · mui/material-ui (original) (raw)
- I have followed (at least) the PR section of the contributing guide.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes deprecated CircularProgress CSS utility classes (circleDeterminate, circleIndeterminate) across the Material UI source and documentation, and updates tests/migration guidance to rely on the non-deprecated class combinations.
Changes:
- Removed deprecated class keys from
circularProgressClassesand stopped generating/applying them inCircularProgress. - Updated unit tests to assert
indeterminateon the root andcircleon the<circle>element. - Updated API docs JSON and added an Upgrade-to-v9 migration note for the removed classes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/mui-material/src/CircularProgress/circularProgressClasses.ts | Removes deprecated class keys from the public classes interface and generated utility classes. |
| packages/mui-material/src/CircularProgress/CircularProgress.js | Stops composing/applying the deprecated variant-specific circle classes and removes them from the overrides resolver. |
| packages/mui-material/src/CircularProgress/CircularProgress.test.js | Updates assertions to match the new class strategy (indeterminate on root, circle on circle). |
| docs/translations/api-docs/circular-progress/circular-progress.json | Removes deprecated class entries from translated API docs content. |
| docs/pages/material-ui/api/circular-progress.json | Removes deprecated class entries from the API documentation data. |
| docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md | Adds a v9 upgrade note describing the removed classes and suggested replacements/codemod. |
For now, in the codemod, the actual.js looks like this:
import { circularProgressClasses } from '@mui/material/CircularProgress';
('& .MuiCircularProgress-circleDeterminate');
('& .MuiCircularProgress-circleIndeterminate');
& .${circularProgressClasses.circleDeterminate};
& .${circularProgressClasses.circleIndeterminate};
Last 2 entries won't work anymore, because we are removing those classes. How are we changing the codemod in this case?
@ZeeshanTamboli @siriwatknp @mj12albert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})