[button] Document type attribute on ButtonBase by mj12albert · Pull Request #48146 · mui/material-ui (original) (raw)
•
edited by oliviertassinari
Loading
| /** |
|---|
| * @ignore |
| */ |
| type: PropTypes.oneOfType([PropTypes.oneOf(['button', 'reset', 'submit']), PropTypes.string]), |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this considered a breaking change? probably not since we are expanding the allowed values.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah widening the type is ok ~
| */ |
|---|
| touchRippleRef?: React.Ref | undefined; |
| /** |
| * The [type](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/button#type) attribute applied to the `button` element. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we expect the ButtonBase to also be a non-native button, maybe we need to change the documentation to reflect that.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as Silviu.
[button][button base] Document [button] Document type attributetype attribute
[button] Document [button] Document type attributetype attribute on ButtonBae
[button] Document [button] Document type attribute on ButtonBaetype attribute on ButtonBase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})