[button][fab][menu item][list item button] Remove duplicated className entries by silviuaavram · Pull Request #48213 · mui/material-ui (original) (raw)

I think we should omit classes.root when we propagate the classes prop instead. We should do that on all components using ButtonBase.

What I meant was doing this:

<ButtonRoot
  ownerState={ownerState}
  className={clsx(contextProps.className, className, classes.root, positionClassName)}
  component={component}
  disabled={disabled || loading}
  focusRipple={!disableFocusRipple}
  focusVisibleClassName={clsx(classes.focusVisible, focusVisibleClassName)}
  ref={ref}
  internalNativeButton
  type={type}
  id={loading ? loadingId : idProp}
  {...other}
  // classes.root is already propagated in the className prop
  classes={{...classes, root: {}}}
>