[select] Support single-pointer-cycle selection and pointer cancellation by mj12albert · Pull Request #48328 · mui/material-ui (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Conversation
Comment on lines +26 to +27
| const SELECTED_MOUSE_UP_DELAY = 400; |
|---|
| const UNSELECTED_MOUSE_UP_DELAY = 200; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this fixes the bug reported in #46665: StackBlitz (this PR build)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! This is a nice improvement to Select.
I added two things:
- Code comment about scheduling mouseup delay: e824998
- Test for mouseup closes the menu on selected item only after the 400ms delay: 42f21ac I believe this was missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Labels
2 participants
