[icon button] Remove unused color palette mapping in styles by sai6855 · Pull Request #48353 · mui/material-ui (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Merged
merged 1 commit into
Apr 22, 2026
Conversation
This pr simplifies the styling logic for the IconButtonRoot component in IconButton.js by removing redundant code related to theme palette processing.
sai6855 marked this pull request as ready for review
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies IconButtonRoot styling by removing a redundant palette-variant mapping and consolidating the per-color variant style into a single theme.palette iteration.
Changes:
- Removed the duplicate
Object.entries(theme.palette)variant generation. - Kept behavior by merging
colorand--IconButton-hoverBgstyle definitions into the remaining per-color variant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
ZeeshanTamboli changed the title
[Iconbutton] Remove unused color palette mapping in IconButton styles [icon button] Remove unused color palette mapping in styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})