Disallow impossible values for fail_under by miketheman · Pull Request #746 · nedbat/coveragepy (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Since there's no way were likely to achieve greater than 100% code coverage,
disallow usage of any value above 100.

Resolves #743

Signed-off-by: Mike Fiedler miketheman@gmail.com

I tried to find a place to implement this other than a method that currently only returns a bool - but I didn't find anywhere that configs are validated, so I hope this is ok.

Very open to feedback here!

Thanks! I took a quick look earlier, and I think I would have put the check in the same place you did.

I wouldn't make the message so flip :) Feel free to add yourself to the CONTRIBUTORS file. :)

@nedbat I updated the error message to be a little less... opinionated. 😀

Codecov failure appears once I force-pushed the branch, it should probably re-report at some later time?

Since there's no way were likely to achieve greater than 100% code coverage, disallow usage of any value above 100.

Resolves nedbat#743

Signed-off-by: Mike Fiedler miketheman@gmail.com