Make so line number not copied by enrh · Pull Request #1717 · nedbat/coveragepy (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Within the htmlcov output, there are line numbers for the code. This update makes so when you highlight the code the line numbers are not included.

becomes

Dang it! I will work through the errors :)

Thanks for this. Small changes can be very useful. The .css files are generated from .scss files, so the edits should start there. Maybe I need to add more to the .css files to alert people, or to the contributing docs.

Maybe I need to add more to the .css files to alert people, or to the contributing docs.

Actually I think it's reasonable that I should have noticed style.scss :) I have updated and run make css for good measure, and it did not change the files I had updated by hand.

Maybe I need to add more to the .css files to alert people, or to the contributing docs.

Actually I think it's reasonable that I should have noticed style.scss :) I have updated and run make css for good measure, and it did not change the files I had updated by hand.

Also there is this

coverage/htmlfiles/style.css:/* Don't edit this .css file. Edit the .scss file instead! */

I believe the checks failed because of a GitHub backend timeout or something unrelated to the code. Are you able to restart or would you prefer I make a faux commit and then undo the commit?

nedbat added a commit that referenced this pull request

Dec 19, 2023

enrh deleted the rh/userselect branch

December 20, 2023 00:23

You are welcome! Thank you!

renovate bot referenced this pull request in allenporter/flux-local

Dec 24, 2023

2 participants