Allow customization of input metadata delimiter by victorlin · Pull Request #1196 · nextstrain/augur (original) (raw)

@victorlin victorlin marked this pull request as ready for review

April 7, 2023 22:21

tsibley

victorlin

@victorlin

Previously, there was hardcoded support for , and \t. Remove the hardcoding by:

  1. Making valid delimiters a required parameter to read_metadata().
  2. In subcommands, adding a new flag --metadata-valid-delimiters with a default of the previously hardcoded delimiters, and passing that list into read_metadata().

@victorlin

@victorlin

These examples are already shown in the help text with the default value.

@victorlin

The previous wording of these option descriptions did not rule out using multiple values at once. This change makes it clear that only one value is inferred.

@victorlin

Copy useful wording from the corresponding parameter description in augur.io.metadata.read_metadata().

@victorlin victorlin deleted the victorlin/metadata-valid-delimiters branch

April 12, 2023 18:39

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})