io: Parse metadata with C engine, restrict to either CSV or TSV by victorlin · Pull Request #812 · nextstrain/augur (original) (raw)

@victorlin victorlin changed the titleio: Parse metadata with C engine and tab separator io: Parse metadata with C engine, restrict to either CSV or TSV

Mar 29, 2023

@victorlin victorlin marked this pull request as ready for review

March 29, 2023 22:48

joverlee521

@victorlin

@victorlin

Previously, the delimiter could be anything arbitrary. However, all Augur subcommands that use this function only advertise compatibility with CSV and TSV. I don't think there's a good reason to support arbitrary delimiters.

@victorlin

The python engine was only used to detect the delimiter. Now that the delimiter is detected separately, use the C engine since it is faster.

@victorlin

@victorlin

Avoids re-defining this list at each use case and prevents them from getting out of sync.

@victorlin victorlin deleted the victorlin/io/use-c-engine-parsing branch

March 31, 2023 20:37

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})