Fix Asia weighted sampling by victorlin · Pull Request #1150 · nextstrain/ncov (original) (raw)

added 4 commits

August 26, 2024 10:56

@victorlin

The temporal grouping attribute was changed from 'week' to 'year month' inadvertently in "Use population-based weighted sampling for Asia builds" (bc3f69e). Revert it back to 'week'.

@victorlin

This has been superseded by the following comment on country grouping with population size weights.

@victorlin

The grouping information is not necessary here and became inaccurate with the switch to country-based weighted sampling. It is only necessary for other regions to distinguish nextstrain_region_grouped_by_country_* from nextstrain_region_grouped_by_division_*.

@victorlin

Follow-up to "Use population-based weighted sampling for Asia builds" (bc3f69e) and subsequent fixes. Those were only applied to the open and gisaid profiles, inadvertently skipping the gisaid-21L profile.

This was referenced

Aug 26, 2024

@trvrb trvrb deleted the victorlin/fix-asia-weighted-sampling branch

September 26, 2024 23:24

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})