switch from warning to debug when upstream labels are empty by pdabelf5 · Pull Request #724 · nginx/nginx-prometheus-exporter (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks14 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Proposed changes

Turn down logging when upstream labels are empty.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING
guide
I have proven my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have ensured the README is up to date
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 3.87%. Comparing base (15b84c1) to head (b64d93e).

Files	Patch %	Lines
collector/nginx_plus.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@ ## main #724 +/- ##

Coverage 3.87% 3.87%

Files 5 5
Lines 1316 1316

Hits 51 51
Misses 1265 1265

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pdabelf5 added a commit that referenced this pull request

May 29, 2024

pdabelf5 added a commit that referenced this pull request

May 29, 2024

This was referenced

Jun 2, 2024

vepatel linked an issue

Jun 4, 2024

that may beclosed by this pull request

@pdabelf5 @oseoin @j1m-ryan this issue is still not resolved and we are getting level=debug ts=2024-06-17T07:28:09.172Z caller=nginx_plus.go:849 msg="wrong number of labels for upstream peer, empty labels will be used instead" upstream=tritonExternalSelfHosted-dev peer expected=1 got=0

can you please look into this at earliest since this is serious performance degradation for nginx-plus users .

lucacome added a commit that referenced this pull request

Jul 17, 2024