Add GitHub Action workflow for F5 CLA integration by TasoOneAsia · Pull Request #754 · nginx/nginx-prometheus-exporter (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits2 Checks15 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Proposed changes

An updated version of #661 that includes a GitHub action workflow integrating the F5 CLA into the typical GitHub pull-request flow for individual contributors.

As part of this workflow's configuration, the following usernames were marked as F5 maintainers:

• lucacome
• pleshakov

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING guide
• I have proven my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have ensured the README is up to date
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

I don't know if @pleshakov still wants to be a maintainer

@lucacome I can remove him from this changeset if desired. However, there isn't much of a net-negative to being listed, all it does is prevents the bot from being implicitly triggered to prompt for a CLA upon a PR to main.

In an ideal world, the maintainer allowlist would be defined at the organization level instead of per-project, but our chosen solution does not have that functionality for the timebeing.

@TasoOneAsia sounds good to me to leave him there.

Is this ready to be merged?

lucacome changed the titleci(f5-cla): add GH action workflow for F5 CLA integration Add GitHub Action workflow for F5 CLA integration

Jul 16, 2024

This was referenced

Jul 28, 2024