doc: mark settings as optional and add callback · nodejs/node@119f83b (original) (raw)

Original file line number Diff line number Diff line change
@@ -572,12 +572,17 @@ Provides miscellaneous information about the current state of the
572 572
573 573 An object describing the current status of this `Http2Session`.
574 574
575 -#### http2session.settings(settings)
575 +#### http2session.settings([settings][, callback])
576 576 <!-- YAML
577 577 added: v8.4.0
578 578 -->
579 579
580 580 * `settings` {HTTP/2 Settings Object}
581 +* `callback` {Function} Callback that is called once the session is connected or
582 + right away if the session is already connected.
583 +* `err` {Error|null}
584 +* `settings` {HTTP/2 Settings Object} The updated `settings` object.
585 +* `duration` {integer}
581 586
582 587 Updates the current local settings for this `Http2Session` and sends a new
583 588 `SETTINGS` frame to the connected HTTP/2 peer.
@@ -2232,7 +2237,7 @@ Returns an object containing the default settings for an `Http2Session`
2232 2237 instance. This method returns a new object instance every time it is called
2233 2238 so instances returned may be safely modified for use.
2234 2239
2235 -### http2.getPackedSettings(settings)
2240 +### http2.getPackedSettings([settings])
2236 2241 <!-- YAML
2237 2242 added: v8.4.0
2238 2243 -->