deps: cherry-pick 26b145a from upstream V8 · nodejs/node@59fa7f1 (original) (raw)

2 files changed

lines changed

Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@
38 38
39 39 # Reset this number to 0 on major V8 upgrades.
40 40 # Increment by one for each non-official patch applied to deps/v8.
41 -'v8_embedder_string': '-node.7',
41 +'v8_embedder_string': '-node.8',
42 42
43 43 ##### V8 defaults for Node.js #####
44 44
Original file line number Diff line number Diff line change
@@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name {
2631 2631 public:
2632 2632 virtual ~ExternalStringResourceBase() = default;
2633 2633
2634 -V8_DEPRECATE_SOON("Use IsCacheable().",
2635 -virtual bool IsCompressible() const) {
2634 +V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) {
2636 2635 return false;
2637 2636 }
2638 2637
@@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name {
2641 2640 * ExternalStringResource::data() may be cached, otherwise it is not
2642 2641 * expected to be stable beyond the current top-level task.
2643 2642 */
2644 -virtual bool IsCacheable() const {
2645 -#if __clang__
2646 -#pragma clang diagnostic push
2647 -#pragma clang diagnostic ignored "-Wdeprecated-declarations"
2648 -#endif
2649 -return !IsCompressible();
2650 -#if __clang__
2651 -#pragma clang diagnostic pop
2652 -#endif
2653 - }
2643 +virtual bool IsCacheable() const { return true; }
2654 2644
2655 2645 protected:
2656 2646 ExternalStringResourceBase() = default;