build,deps,v8: tie up loose ends · nodejs/node@6608cf2 (original) (raw)

`@@ -8,6 +8,7 @@

`

8

8

`'v8_random_seed%': 314159265,

`

9

9

`'v8_vector_stores%': 0,

`

10

10

`'v8_embed_script%': "",

`

``

11

`+

Placeholder. For upstream V8, this includes test files that Node.js does not need.

`

11

12

`'v8_extra_library_files%': [],

`

12

13

`'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',

`

13

14

`'v8_os_page_size%': 0,

`

418

419

`'toolsets': ['host', 'target'],

`

419

420

`'dependencies': [

`

420

421

`'mksnapshot#host',

`

421

``

`-

'js2c#host',

`

``

422

`+

'js2c_extras#host', # TODO(refack) get rid of this.

`

``

423

`+

This has effectively become a noop for Node.js,

`

``

424

`+

but the V8 code still tried to acess the code this generates.

`

``

425

`+

Refs: https://github.com/nodejs/node/blob/169b7f1f3b3751289f24678930e6a5731464ebc9/deps/v8/src/bootstrapper.cc#L5172-L5174

`

422

426

` ],

`

423

427

` }, {

`

424

428

`'toolsets': ['target'],

`

425

429

`'dependencies': [

`

426

430

`'mksnapshot',

`

``

431

`+

'js2c_extras',

`

427

432

` ],

`

428

433

` }],

`

429

434

` ['component=="shared_library"', {

`

538

543

`'conditions': [

`

539

544

` ['want_separate_host_toolset==1', {

`

540

545

`'toolsets': ['host', 'target'],

`

541

``

`-

'dependencies': ['js2c#host'],

`

``

546

`+

'dependencies': [ 'js2c_extras#host', ],

`

542

547

` }, {

`

543

548

`'toolsets': ['target'],

`

544

``

`-

'dependencies': ['js2c#target'],

`

``

549

`+

'dependencies': [ 'js2c_extras', ],

`

545

550

` }],

`

546

551

` ['component=="shared_library"', {

`

547

552

`'defines': [

`

2508

2513

` },

`

2509

2514

` }, # v8_libsampler

`

2510

2515

` {

`

2511

``

`-

'target_name': 'js2c',

`

``

2516

`+

'target_name': 'js2c_extras',

`

2512

2517

`'type': 'none',

`

2513

2518

`'conditions': [

`

2514

2519

` ['want_separate_host_toolset==1', {

`

`@@ -2517,14 +2522,6 @@

`

2517

2522

`'toolsets': ['target'],

`

2518

2523

` }],

`

2519

2524

` ],

`

2520

``

`-

'variables': {

`

2521

``

`-

'library_files': [

`

2522

``

`-

'../src/js/macros.py',

`

2523

``

`-

'../src/message-template.h',

`

2524

``

`-

'../src/js/prologue.js',

`

2525

``

`-

],

`

2526

``

`-

'libraries_extras_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-extras.bin',

`

2527

``

`-

},

`

2528

2525

`'actions': [

`

2529

2526

` {

`

2530

2527

`'action_name': 'js2c_extras',

`

`@@ -2535,14 +2532,12 @@

`

2535

2532

`'outputs': ['<(SHARED_INTERMEDIATE_DIR)/extras-libraries.cc'],

`

2536

2533

`'action': [

`

2537

2534

`'python',

`

2538

``

`-

'../tools/js2c.py',

`

2539

``

`-

'<(SHARED_INTERMEDIATE_DIR)/extras-libraries.cc',

`

2540

``

`-

'EXTRAS',

`

2541

``

`-

'<@(v8_extra_library_files)',

`

``

2535

`+

'../tools/js2c.py', '<@(_outputs)',

`

``

2536

`+

'EXTRAS', '<@(v8_extra_library_files)',

`

2542

2537

` ],

`

2543

2538

` },

`

2544

2539

` ],

`

2545

``

`-

}, # js2c

`

``

2540

`+

}, # js2c_extras

`

2546

2541

` {

`

2547

2542

`'target_name': 'torque_base',

`

2548

2543

`'type': '<(component)',

`