lib: move DEP0006 to end of life · nodejs/node@d4934ae (original) (raw)

3 files changed

lines changed

Original file line number Diff line number Diff line change
@@ -160,6 +160,9 @@ outside `node_modules` in order to better target developers, rather than users.
160 160 ### DEP0006: child\_process options.customFds
161 161 <!-- YAML
162 162 changes:
163 + - version: REPLACEME
164 + pr-url: https://github.com/nodejs/node/pull/25279
165 + description: End-of-Life.
163 166 - version:
164 167 - v4.8.6
165 168 - v6.12.0
@@ -171,7 +174,7 @@ changes:
171 174 description: Documentation-only deprecation.
172 175 -->
173 176
174 -Type: Runtime
177 +Type: End-of-Life
175 178
176 179 Within the [`child_process`][] module's `spawn()`, `fork()`, and `exec()`
177 180 methods, the `options.customFds` option is deprecated. The `options.stdio`
Original file line number Diff line number Diff line change
@@ -22,9 +22,7 @@
22 22 'use strict';
23 23
24 24 const util = require('util');
25 -const {
26 - deprecate, convertToValidSignal, getSystemErrorName
27 -} = require('internal/util');
25 +const { convertToValidSignal, getSystemErrorName } = require('internal/util');
28 26 const { isArrayBufferView } = require('internal/util/types');
29 27 const debug = util.debuglog('child_process');
30 28 const { Buffer } = require('buffer');
@@ -384,20 +382,6 @@ Object.defineProperty(exports.execFile, util.promisify.custom, {
384 382 value: customPromiseExecFunction(exports.execFile)
385 383 });
386 384
387 -const _deprecatedCustomFds = deprecate(
388 -function deprecateCustomFds(options) {
389 -options.stdio = options.customFds.map(function mapCustomFds(fd) {
390 -return fd === -1 ? 'pipe' : fd;
391 -});
392 -}, 'child_process: options.customFds option is deprecated. ' +
393 -'Use options.stdio instead.', 'DEP0006');
394 -
395 -function _convertCustomFds(options) {
396 -if (options.customFds && !options.stdio) {
397 -_deprecatedCustomFds(options);
398 -}
399 -}
400 -
401 385 function normalizeSpawnArguments(file, args, options) {
402 386 validateString(file, 'file');
403 387
@@ -526,8 +510,6 @@ function normalizeSpawnArguments(file, args, options) {
526 510 }
527 511 }
528 512
529 -_convertCustomFds(options);
530 -
531 513 return {
532 514 file: file,
533 515 args: args,