net,http2: merge setTimeout code by ZYSzys · Pull Request #25084 · nodejs/node (original) (raw)
Can you give me some advice how to implement exactly ?
IMO I would just leave the implementations separate for now.
IMHO, Isn't the explicit check for
typeof callback
strictly better ?
Possibly, but it could be a semver-major-like change? Although EventEmitter
should reject non-function event handlers...
EDIT: It appears that EventEmitter
throws a different error, so that makes me feel like it would be more semver-major-ish.