deps,v8: silence V8 self-deprecation warnings by refack · Pull Request #25394 · nodejs/node (original) (raw)
just to clarify, these are warnings only for V8 code itself, not Node.js using V8 deprecated functions right?
As I understand it, this would disable deprecation warnings for addons as well, unless they explicitly enable it?
These settings are just for the the compilation of the V8 code itself (I should not have turned them on in the first place when we migrated them from the GN setup).
For all other code (the files in /src/ and addons) to get v8.h to emit those warnings we explicitly define these flags in
| # Defines these mostly for node-gyp to pickup, and warn addon authors of |
|---|
| # imminent V8 deprecations, also to sync how dependencies are configured. |
| 'defines': [ |
| 'V8_DEPRECATION_WARNINGS', |
| 'V8_IMMINENT_DEPRECATION_WARNINGS', |
| ], |
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20077/ ✅