build,win: configuration tweaks for faster build with MSVC by refack · Pull Request #25931 · nodejs/node (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always safe? I see in some files where this is defined other headers are included before. With this here, NAPI_EXPERIMENTAL will always be defined, can probably be removed from everywhere in the code.

There is also NODE_WANT_INTERNALS. There is and explicit define in inspector_socket.cc which will be ignored by all headers pulled by these here.

This might be safe, but is not obvious to me. Might also become difficult to maintain, since anyone not using Windows will only see errors when running CI (if at all).