src: apply clang-tidy rule modernize-use-emplace by gengjiawen · Pull Request #26564 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

gengjiawen

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Mar 10, 2019

@BridgeAR

addaleax

bnoordhuis

@gengjiawen

joyeecheung

@danbev

@gengjiawen

@danbev

@targos

Compilation fails if this is applied on v11.x-staging:

make -C out BUILDTYPE=Release V=
  TOUCH cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  ACTION _home_mzasso_git_nodejs_v11_x_deps_v8_gypfiles_v8_gyp_v8_torque_host_run_torque cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  TOUCH b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  ACTION Generating inspector protocol sources from protocol json b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  TOUCH 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  ACTION Generating node protocol sources from protocol json 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  CXX(target) /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o
../src/inspector_socket.cc: In static member function ‘static int node::inspector::{anonymous}::HttpHandler::OnMessageComplete(parser_t*)’:
../src/inspector_socket.cc:570:43: error: cannot bind bitfield ‘parser->http_parser::upgrade’ to ‘unsigned int&’
                                   parser->upgrade,
                                   ~~~~~~~~^~~~~~~
make[1]: *** [node_lib.target.mk:340: /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o] Error 1

Please open a backport PR or apply the dont-land-on label.

This was referenced

Apr 23, 2019

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.