tls: return correct version from getCipher() by sam-github · Pull Request #26625 · nodejs/node (original) (raw)

OpenSSL 1.0.0 returned incorrect version information. OpenSSL 1.1.0
fixed this, but returning the correct information broke our tests, so
was considered semver-major. Because of this, the version was hard-coded
to the OpenSSL 1.0.0 (incorrect) string in 5fe81c8.

This is ancient history, start returning the correct cipher version.

I considered deprecating version: for a major cycle, but given its been documented as returning an incorred hard-coded string for ages, I don't think changing its meaning in 12.x is risky.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines