Bootstrap: make global.process, global.Buffer getters by guybedford · Pull Request #26882 · nodejs/node (original) (raw)

This implements just the semver major breaking changes from #26334 Restrict process and Buffer globals to CommonJS, which is to make global.process and global.Buffer getters / setters over value properties.

I've split this out because we need two TSC approvals for this to make the 12 major release, if this is to be considered a breaking change.

So this is the bare minimum prerequisite to ensure that #26334 remains possible in the design of ES Modules in Node.js. If we miss this target, it will be very difficult to implement these important security properties later on.

As well as the CIGTM run on that PR, I also ran these builds against Jest running on the ncc test suite, which tests a large number of ecosystem packages as well. These have all been passing fine.

It would be amazing to get those two TSC approvals to be able to ensure these important security approaches for modules remain possible.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines