build: pin Python version in Travis by richardlau · Pull Request #27166 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

richardlau

Travis will be switching the default version of Python from 2.7 to 3.6 on April 16th 2019.

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

Refs: https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

Checklist

@richardlau richardlau added the wip

Issues and PRs that are still a work in progress.

label

Apr 10, 2019

@nodejs-github-bot

This comment has been minimized.

@richardlau

Some notes:
So the Travis documented way of pinning the Python version:

language: python python: '2.7'

doesn't work for non-Python projects such as ours. The Xenial images on Travis have Python 2.7.15, 3.6.7, and 3.7.1: https://docs.travis-ci.com/user/reference/xenial/#python-support
Used pyenv to switch to 3.6.7 and the compilation jobs fail because we haven't updated configure which specifically looks for a Python 2 to reexecute itself (fix pending in #25878).

So we do need to pin to 2.7.15 in the short term. Updating this PR...

@richardlau richardlau changed the titleWIP build: pin Python version in Travis build: pin Python version in Travis

Apr 10, 2019

@richardlau richardlau added python

PRs and issues that require attention from people who are familiar with Python.

and removed wip

Issues and PRs that are still a work in progress.

labels

Apr 10, 2019

@richardlau

According to https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

On April 16th 2019, the default Python version used to run your builds will be updated from Python 2.7 to Python 3.6

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

cc FYI @nodejs/python @cclauss

This was referenced

Apr 10, 2019

thefourtheye

@cclauss

@cclauss

We have a list of things to get done... #25789. What percentage of build machine have Python 3 loaded?

@richardlau

@richardlau richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 10, 2019

@richardlau

Travis will be switching the default version of Python from 2.7 to 3.6. Our configuration and build scripts are not quite ready for Python 3 yet, so pin the version of Python to 2.7.

@richardlau

BridgeAR

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Apr 15, 2019

@richardlau @BridgeAR

@BridgeAR

This was referenced

Apr 23, 2019

This was referenced

Apr 23, 2019

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

build

Issues and PRs related to build files or the CI.

python

PRs and issues that require attention from people who are familiar with Python.