deps: upgrade to libuv 1.28.0 by cjihrig · Pull Request #27241 · nodejs/node (original) (raw)

@cjihrig the following should fix the test:

diff --git a/test/parallel/test-fs-copyfile-respect-permissions.js b/test/parallel/test-fs- index 34697ee..3f8d025 100644 --- a/test/parallel/test-fs-copyfile-respect-permissions.js +++ b/test/parallel/test-fs-copyfile-respect-permissions.js @@ -23,7 +23,9 @@ function beforeEach() { fs.chmodSync(dest, '444');

const check = (err) => {

• assert.strictEqual(err.code, 'EACCES');

• const expected = ['EACCES', 'EPERM'];
• assert(expected.includes(err.code),

•       `err.code '${err.code}' is neither '${expected.join('\' nor \'')}'`);

  assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest'); return true; };

Also please remove the entries in test/known_issues/known_issues.status:

diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status index d7e0b54..3463f0a 100644 --- a/test/known_issues/known_issues.status +++ b/test/known_issues/known_issues.status @@ -7,24 +7,18 @@ prefix known_issues [true] # This section applies to all platforms

[$system==win32] -test-fs-copyfile-respect-permissions: SKIP

[$system==linux] test-vm-timeout-escape-promise: PASS,FLAKY -test-fs-copyfile-respect-permissions: SKIP

[$system==macos]

[$system==solaris] -test-fs-copyfile-respect-permissions: SKIP

[$system==freebsd] -test-fs-copyfile-respect-permissions: SKIP

[$system==aix] -test-fs-copyfile-respect-permissions: SKIP

[$arch==arm]

https://github.com/nodejs/node/issues/24120

test-vm-timeout-escape-nexttick: PASS,FLAKY -test-fs-copyfile-respect-permissions: SKIP