n-api: do not require JS Context for napi_async_destroy() by addaleax · Pull Request #27255 · nodejs/node (original) (raw)
By the way, it sounds like there may not be any more v8.x semver-minor releases. (/cc @MylesBorins @nodejs/lts)
I do think that this, as a bug fix, should end up in a v10.x and v8.x release, respectively, according to the usual rules for bug fixes. However, the first commit here is technically semver-minor. So, that leaves a few options:
- Remove the semver-minor label. This makes this fit in well with our LTS workflow, is super-simple, but is also just plain wrong in terms of what the relevant commit does – it adds an API.
- Make the added function overload purely internal in backports. This is also easy, but seems to go against the best interests of our users, because they may need access to a function like that in the same way that we use the added function here internally. (It might be worth noting that this functionality isn’t all that widely used, likely.)
- Convince the LTS team to do another v8.x semver-minor release. I would expect that this is, unlike the other options, not an easy thing to do.
Any preferences?