ci: extend Windows Node.js workflow timeout by mcollina · Pull Request #5426 · nodejs/undici (original) (raw)
Summary
Increase the reusable Node.js workflow timeout from 20 to 30 minutes for Windows jobs only.
Motivation
Windows CI on main has been getting cancelled while running WPT near the 20-minute job timeout. The WPT server shutdown lines in the logs are cleanup during cancellation, not a separate WPT assertion failure.
Evidence from the first affected run (0d6ecc571095, run 27418354554):
- Windows Node.js 22 job started at
13:21:40. npm run test:wptstarted at13:30:42.- WPT was still running at
13:41:40. - WPT server cleanup logged at
13:41:40. - The job was cancelled at
13:41:42, right at the 20-minute job timeout boundary.
This keeps the existing 20-minute timeout for non-Windows jobs and gives Windows enough budget to finish WPT and cleanup reliably.
Validation
git diff --check- Parsed
.github/workflows/nodejs.ymlwith the repositoryyamlpackage - Commit hook ran
npm run lint