Avoid using cmake glob vars if we are a subproject v2 by nkh-lab · Pull Request #1459 · open-source-parsers/jsoncpp (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
If jsoncpp is a subproject (like a git submodule), setting the global cmake variables affect the entire project (changes the structure of the output folders) and these changes prevent it.
This was referenced
Jan 11, 2023
IMO it's a very good and necessary fix!
@BillyDonahue
Could You merge it?
Anyone know what's up with Travis CI? It seems to be blocked.
Anyone know what's up with Travis CI? It seems to be blocked.
Maybe you've exhausted your current allowance of sponsored "build minutes for OSS" and have to apply for the next batch?
Anyone know what's up with Travis CI? It seems to be blocked.
Maybe you've exhausted your current allowance of sponsored "build minutes for OSS" and have to apply for the next batch?
Yes that's what's up.
Builds have been temporarily disabled for private and public repositories due to a negative credit balance.
@cdunn2001 is the contact for that.
We could wait out the month and rebuild when we get the OSS credits refresh.
Anyone know what's up with Travis CI? It seems to be blocked.
Maybe you've exhausted your current allowance of sponsored "build minutes for OSS" and have to apply for the next batch?
Yes that's what's up.
Builds have been temporarily disabled for private and public repositories due to a negative credit balance.
@cdunn2001 is the contact for that. We could wait out the month and rebuild when we get the OSS credits refresh.
Waiting out the month seems reasonable. It's a bummer that the open screen credits are shared between all of the @open-source-parsers repositories, considering we haven't really had any code checked into JsonCpp in over six months.
Looks like the PR is stuck...
ok. it's a good change. We just can't get CI to validate it.
We can just YOLO it and be ready to revert if necessary I guess.
If jsoncpp is a subproject (like a git submodule), setting the global cmake variables affect the entire project (changes the structure of the output folders) and these changes prevent it.
nkh-lab added a commit to nkh-lab/usb-relay-module that referenced this pull request
nkh-lab added a commit to nkh-lab/usb-relay-module that referenced this pull request