Update meson build requirement by baylesj · Pull Request #952 · open-source-parsers/jsoncpp (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Currently, we have a build type warning due to listing a requirement for
meson build version that doesn't implement features we use in our build
file. The minimum meson build version required is actually 0.50.0, so
this PR updates our meson.build file to depend on 0.50.0.

Currently, we have a build type warning due to listing a requirement for meson build version that doesn't implement features we use in our build file. The minimum meson build version required is actually 0.50.0, so this PR updates our meson.build file to depend on 0.50.0.

We still need directions on how to build with Meson. All the cmake support is user-provided, not official. We actually use meson in TravisCI.

I'll add a PR for Meson directions, plus Meson updates ...

Hmmm. I don't actually see a merge commit for the README changes. Well, that's what I meant to comment on...

Oh, I see. That comment was moved to CONTRIBUTING.md. Ok.

I just updated Meson in my Homebrew, which took some time. Apparently we no longer support older Meson at all, which is fine...

I was getting this:

    DEPRECATION: Project targetting '>= 0.41.1' but tried to use feature depreca
    Build targets in project: 3
    WARNING: Deprecated features used:
     * 0.48.0: {'python3 module'}

So I did this:

-python = import('python3').find_python() +python = find_program('python3', 'python')

But I no longer see that deprecation warning either way. Strange. It does seem to be deprecated:

• https://mesonbuild.com/Python-3-module.html

This module is deprecated and replaced by the python module.

2 participants