[cmd/mdatagen] Do not generate redundant reaggregation config options by dmitryax · Pull Request #14689 · open-telemetry/opentelemetry-collector (original) (raw)

@dmitryax

Do not generate the following metrics re-aggregation config options for metrics that don't have any attributes that can be aggregated:

Merged via the queue into open-telemetry:main with commit 92d7303

Mar 5, 2026

83 of 88 checks passed

@dmitryax dmitryax deleted the not-generate-agg-config-option branch

March 5, 2026 02:58

dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this pull request

Mar 6, 2026

@dmitryax

Follow-up to open-telemetry#14689.

When reaggregation_enabled: true, instead of a shared MetricConfig for all metrics, each metric now gets its own generated Config type containing only the fields relevant to it:

EnabledAttributes is typed as []<MetricName>AttributeKey rather than []string, with a generated enum constant per attribute (e.g. DefaultMetricAttributeKeyStringAttr). This makes the API type-safe and self-documenting, and eliminates the runtime definedAttributes/requiredAttributes slice allocations that were previously needed for validation.

Validate() is generated per-metric with the valid attribute set and required attributes hardcoded, producing descriptive errors:

Breaking change: Components using reaggregation_enabled: true will need to update references from MetricConfig to their per-metric Config type.

dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this pull request

Mar 6, 2026

@dmitryax

Follow-up to open-telemetry#14689.

When reaggregation_enabled: true, instead of a shared MetricConfig for all metrics, each metric now gets its own generated Config type containing only the fields relevant to it:

EnabledAttributes is typed as []<MetricName>AttributeKey rather than []string, with a generated enum constant per attribute (e.g. DefaultMetricAttributeKeyStringAttr). This makes the API type-safe and self-documenting, and eliminates the runtime definedAttributes/requiredAttributes slice allocations that were previously needed for validation.

Validate() is generated per-metric with the valid attribute set and required attributes hardcoded, producing descriptive errors:

Breaking change: Components using reaggregation_enabled: true will need to update references from MetricConfig to their per-metric Config type.

dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this pull request

Mar 6, 2026

@dmitryax

Follow-up to open-telemetry#14689.

When reaggregation_enabled: true, instead of a shared MetricConfig for all metrics, each metric now gets its own generated Config type containing only the fields relevant to it:

EnabledAttributes is typed as []<MetricName>AttributeKey rather than []string, with a generated enum constant per attribute (e.g. DefaultMetricAttributeKeyStringAttr). This makes the API type-safe and self-documenting, and eliminates the runtime definedAttributes/requiredAttributes slice allocations that were previously needed for validation.

Validate() is generated per-metric with the valid attribute set and required attributes hardcoded, producing descriptive errors:

Breaking change: Components using reaggregation_enabled: true will need to update references from MetricConfig to their per-metric Config type.

TimoBehrendt pushed a commit to TimoBehrendt/tracebasedlogsampler that referenced this pull request

Mar 26, 2026

…ocessortest to v0.148.0 (#40)

This PR contains the following updates:

Package Change Age Confidence
go.opentelemetry.io/collector/processor/processortest v0.147.0v0.148.0 age confidence

Release Notes

open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/processor/processortest)

v0.148.0

Compare Source

❗ Known Issues ❗
🛑 Breaking changes 🛑
💡 Enhancements 💡
🧰 Bug fixes 🧰

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Renovate Bot.

Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/40 Reviewed-by: t.behrendt t.behrendt@noreply.localhost Co-authored-by: Renovate Bot renovate@t00n.de Co-committed-by: Renovate Bot renovate@t00n.de

TimoBehrendt pushed a commit to TimoBehrendt/tracebasedlogsampler that referenced this pull request

Mar 26, 2026

…1.54.0 (#33)

This PR contains the following updates:

Package Change Age Confidence
go.opentelemetry.io/collector/confmap v1.50.0v1.54.0 age confidence

Release Notes

open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/confmap)

v1.54.0

❗ Known Issues ❗
🛑 Breaking changes 🛑
💡 Enhancements 💡
🧰 Bug fixes 🧰

v1.53.0

💡 Enhancements 💡
🧰 Bug fixes 🧰

v1.52.0

v1.51.0

💡 Enhancements 💡
🧰 Bug fixes 🧰

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Renovate Bot.

Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/33 Reviewed-by: t.behrendt t.behrendt@noreply.localhost Co-authored-by: Renovate Bot renovate@t00n.de Co-committed-by: Renovate Bot renovate@t00n.de

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})