Add schema for composite sampler by anuraaga · Pull Request #390 · open-telemetry/opentelemetry-configuration (original) (raw)
Conversation
Fixes #340
Essentially proposal from here but left out delegate:
#340 (comment)
Didn't actually agree on concensus in the issue so happy to make any changes, just wanted to keep the ball rolling.
| "maxProperties": 1, |
|---|
| "properties": { |
| "always_off": { |
| "$ref": "#/$defs/AlwaysOffSampler" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency with ExperimentalComposableParentBasedSampler would suggest separate ExperimentalComposableAlwaysOn/ExperimentalComposableAlwaysOff sampler as defined in the spec, but it seems silly at the same time.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed felt a bit silly but went with it - from a configuration standpoint it shouldn't matter, but we could imagine implementations in SDKs that map these types to actual SDK types in which case the mapping would be incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
