feat: support metrics for otelmux by martinyonatann · Pull Request #6648 · open-telemetry/opentelemetry-go-contrib (original) (raw)

Thank you for this! ❤️

This PR does a lot more than just setup semconv.
In order to allow for better reviews, could you split it into multiple PRs?
From a first look, I'd do at least four:

• Setup the body wrapper and use it.
• Change the default span name behavior.
• Introduce the semconv package, and use it with tracing only.
• Introduce metrics support.

Striving for atomic PRs (each PR changes a single thing) makes for much speeder reviews.

[](/apps/github-advanced-security)

thankyou for the feedback @dmathieu ! ❤️
You're absolutely right, this PR ended up covering more ground than initially intended. i appreciate your suggestion to split it into atomic PRs for easier review. i'll get started on breaking it down into the following :

• 1. Setting up the body wrapper and using it Setup body wrapper in otelmux #6650
• 2. Changing the default span name behavior.
• 3. introducing the semconv package and using it with tracing only. Migrate to semconv for otelmux and implement the package in tracing #6652
• 4. Adding metrics support.

This approach should make the review process smother and more efficient. i'll prioritize reorganizing these changes and will submit the individual PRs soon. Let me know if there are any additional points you'd like me to address.

This was referenced

Jan 20, 2025

martinyonatann changed the titlemigrate to semconv for otelmux #6638 migrate to semconv for otelmux and implementation the package in metrics

Jan 27, 2025

martinyonatann changed the titlemigrate to semconv for otelmux and implementation the package in metrics feat: support metrics for otelmux

Jan 30, 2025

Co-authored-by: Damien Mathieu 42@dmathieu.com

XSAM mentioned this pull request

Mar 5, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})