config: fix issue causing a crash on invalid value by codeboten · Pull Request #6752 · open-telemetry/opentelemetry-go-contrib (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Merged
merged 3 commits into
Feb 12, 2025
Conversation
This addresses a bug that was uncovered in the collector after updating to the latest version of config where an unset value in the NameStringValuePair results in a nil dereferencing.
This addresses a bug that was uncovered in the collector after updating to the
latest version of config where an unset value in the NameStringValuePair results
in a nil dereferencing.
Signed-off-by: Alex Boten 223565+codeboten@users.noreply.github.com
Signed-off-by: Alex Boten 223565+codeboten@users.noreply.github.com
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 75.1%. Comparing base (daafaee) to head (08324a5).
Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #6752 +/- ##
Coverage 75.1% 75.1%
Files 203 203
Lines 18322 18323 +1
- Hits 13768 13775 +7
- Misses 4144 4140 -4
- Partials 410 408 -2
| Files with missing lines | Coverage Δ | |
|---|---|---|
| config/v0.3.0/config.go | 88.6% <100.0%> (+0.1%) | ⬆️ |
... and 1 file with indirect coverage changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})