Upgrade semconv to 1.32.0 for otelmongo by MrAlias · Pull Request #7393 · open-telemetry/opentelemetry-go-contrib (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrAlias The doc.go file should be updated to reflect this update:
// The "OTEL_SEMCONV_STABILITY_OPT_IN" environment variable can be used to opt
// into the latest semantic version:
// - "database": emit latest semantic conventions
// - "": emit v1.21.0 (default) semantic conventions
// - "database/dup": emit v1.21.0 (default) and latest
//
// By default, otelmongo only emits v1.21.0.
It might also be helpful to list what the latest semantic version is.
Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.
Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .
Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.
Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .
@MrAlias I specifically added the word "latest" so you could just drop the update in. The current doc.go files specifies 1.26.0.
Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.
Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .@MrAlias I specifically added the word "latest" so you could just drop the update in. The current doc.go files specifies 1.26.0.
Ah, gotcha. I misunderstood. Sounds like we are in favor of the same result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})