Remove zipkin example by pradhyum6144 · Pull Request #8501 · open-telemetry/opentelemetry-go-contrib (original) (raw)

Removes the deprecated zipkin example following the deprecation of the Zipkin exporter in v1.40.0.

Fixes #8484

Changes

• Removed examples/zipkin/ directory and all its files (Dockerfile, README.md, docker-compose.yml, go.mod, go.sum, main.go)
• Updated versions.yaml to remove zipkin example reference
• Updated .gitignore to remove zipkin binary reference

Verification

• Build verification: Passed
• No remaining references to zipkin example found in codebase
• Total changes: 8 files, 204 deletions

Signed-off-by: pradhyum6144 pradhyum314@gmail.com

@MrAlias can you please review this. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. Thanks for the contribution.

Please add a changelog entry for the removal of this module.

Signed-off-by: pradhyum6144 pradhyum314@gmail.com

Overall, this looks good. Thanks for the contribution.

Please add a changelog entry for the removal of this module.

okay sir i have added the changelog entry. now this pr is ready to review/merge.
Thank you

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (82cfc18) to head (9e67535).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@ ## main #8501 +/- ##

Coverage 82.2% 82.2%

Files 179 179
Lines 13692 13692

Hits 11257 11257
Misses 2033 2033
Partials 402 402

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Tyler Yahn MrAlias@users.noreply.github.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})