Generate semconv/v1.40.0 by ChrsMark · Pull Request #7929 · open-telemetry/opentelemetry-go (original) (raw)
Signed-off-by: ChrsMark chrismarkou92@gmail.com
Signed-off-by: ChrsMark chrismarkou92@gmail.com
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.7%. Comparing base (0f1a224) to head (d26c9ef).
⚠️ Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #7929 +/- ##
Coverage 81.7% 81.7% -0.1%
Files 304 304
Lines 23333 23333- Hits 19080 19079 -1
Misses 3865 3865 - Partials 388 389 +1
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I'd like to wait merging this until after the next release. That way we have time to update semconv used here and in contrib.
Thank's @MrAlias! My intention is to use the new package in the Collector (k8sattributes processor) to validate the promotion of the k8s attributes to Beta.
I'm fine using the package from a merged commit so a release is not necessary.
Thank's @MrAlias! My intention is to use the new package in the Collector (k8sattributes processor) to validate the promotion of the k8s attributes to Beta.
I'm fine using the package from a merged commit so a release is not necessary.
@MrAlias @pellared @XSAM @flc1125 WDYT?
Hey folks, anything else blocking us here?
I meant to merge this so the package would be available, even if we're not using it. But it seems this makes users unhappy as they upgrade their semantic conventions versions but can't use the latest detectors.
dmathieu added a commit that referenced this pull request
pellared pushed a commit that referenced this pull request
But it seems this makes users unhappy as they upgrade their semantic conventions versions but can't use the latest detectors
@dmathieu @pellared is there a way to decouple the existence of the package from the implementations using this?
Right now using the semconv packages from this repo in the Collector means that we need to wait several weeks.
This is not so convenient. Since those are already released Semantic Conventions it should be implementations' responsibility to make use of them at the right time.
@dmathieu @pellared is there a way to decouple the existence of the package from the implementations using this?
It is decoupled but users were very unsatisfied when these were not updated in the same release.
Right now using the semconv packages from this repo in the Collector means that we need to wait several weeks.
We plan to make 2 subsequent releases quickly. One is already in progress. Next one is mainly about dropping Go 1.24 and adding new semconv.
MrAlias added a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})