[common] rename _ref suffix to _strindex by florianl · Pull Request #768 · open-telemetry/opentelemetry-proto (original) (raw)

Conversation

Rename the experimental profiling field suffix from _ref _to _strindex to align with the naming in the profiles proto.

Signed-off-by: Florian Lehner florian.lehner@elastic.co

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered going the other way round and use _ref suffix everywhere since that's more concise?

Have you considered going the other way round and use _ref suffix everywhere since that's more concise?

IIRC we wanted to very clearly emphasize the nature of this referencing which is direct index into the array, as opposed to an indirection via a separate ID field like in pprof.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Reviewers

felixge felixge approved these changes

jsuereth jsuereth approved these changes

jhalliday jhalliday approved these changes

aalexand aalexand approved these changes

tigrannajaryan tigrannajaryan approved these changes

christos68k christos68k approved these changes

+1 more reviewer

Gandem Gandem approved these changes

Reviewers whose approvals may not affect merge requirements