Revert "Preventing containers from being unable to be deleted" by kolyshkin · Pull Request #5153 · opencontainers/runc (original) (raw)

LGTM, thanks for investigating and finding a fix!

Is it always the same test failing? In that case, maybe we can adapt it and add it to runc?

The failures are random, I haven't got to the bottom of it, but even if it is something not entirely kosher that conmon (or conmon tests) do (which results in a race), it worked before and it works with crun so this is a regression.

As for adding runc tests, I was just thinking we can run existing conmon tests. The downside it when conmon tests will break, our CI will break, too, but I guess we can live with that (same as we're living with occasional CRIU failures).

Similarly, we can add podman tests (crun does it already), but those are more heavy weight.