Use pkg-config to find libxml2, falling back to xml2-config if necessary by hughmcmaster · Pull Request #2714 · owasp-modsecurity/ModSecurity (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Debian is taking steps to remove xml2-config in favour of pkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages.
This patch modifies build/libxml.m4 to check for libxml2 via pkg-config, falling back to xml2-config if necessary.
configure.ac: Use pkg-config to find libxml2 Use pkg-config to find libxml2, falling back to xml2-config if necessary
Debian is taking steps to remove xml2-config in favour of pkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages.
This patch modifies build/libxml.m4 to check for libxml2 via pkg-config, falling back to xml2-config if necessary.
Hi @martinhsv, hoping you can look at this MR soon. Debian goes into freeze in January...
Hello @hughmcmaster ,
I wasn't aware of Debian's plan re: xml2-config. Thanks for both raising the issue and submitting the PR.
I'll plan to merge this shortly.
In our other maintained branch (v2/master), it looks to me like the same issue applies in the comparable file (find_xml.m4). Would you be interested in submitting a pull request to update that one as well? (No obligation, of course.)
Thanks, @martinhsv. I'm happy to send a patch for the other branch.
2 participants
