BUG: Fix argument order in call to super by eddiejessup · Pull Request #12924 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

tests added / passed
passes git diff upstream/master | flake8 --diff

super should have arguments (type, object), not (object, type).

I've run test_fast.sh using Python 2.7 and it gives 2 failures relating to language locales (I'm using en_GB). Pretty sure these are unrelated to the commit.

hah I guess we don't have a test for that

can u create a test that hits that path as well

Sure. I could find a concrete sub-class of PandasObject that doesn't implement memory_usage, instantiate that, get its sizeof() and check it returns something of the correct type? For example, from a quick look, looks like the GroupBy class is such a class.

jreback added Bug Compat