Groupby getitem works with all index types by jcrist · Pull Request #13731 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Contributor
•
edited by jorisvandenbossche
Loading
- tests added / passed
- passes
git diff upstream/master | flake8 --diff - whatsnew entry
Previously df.groupby(0)[df.columns] would fail if all column names
were integers (meaning df.columns was an Int64Index). This was
because the implementation of __getitem__ in SelectionMixin was
checking for ABCIndex when it probably should have checked forABCIndexClass.
Current coverage is 84.56% (diff: 100%)
@@ master #13731 diff @@
Files 141 141
Lines 51195 51196 +1
Methods 0 0
Messages 0 0
Branches 0 0
- Hits 43295 43296 +1
Misses 7900 7900
Partials 0 0
Powered by Codecov. Last update e357ea1...b901322
| @@ -3769,6 +3769,21 @@ def test_getitem_list_of_columns(self): |
|---|
| assert_frame_equal(result2, expected) |
| assert_frame_equal(result3, expected) |
| def test_getitem_numeric_column_names(self): |
| df = DataFrame({0: list('abcd') * 2, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the issue number (or in this case PR number) as a comment on the first line?
Looks good to me, some minor comments
Previously df.groupby(0)[df.columns] would fail if all column names
were integers (meaning df.columns was an Int64Index). This was
because the implementation of __getitem__ in SelectionMixin was
checking for ABCIndex when it probably should have checked for
ABCIndexClass.
