DEPR: Patch to_dense behaviour for sparse. by gfyoung · Pull Request #14686 · pandas-dev/pandas (original) (raw)

Patches the following for to_dense:

1. Fix SparseArray.to_dense documentation to refer to SparseArray and not SparseSeries.
2. Deprecate the fill parameter in SparseArray.to_dense, as that parameter was not being respected.
3. Deprecate the sparse_only parameter in SparseSeries.to_dense, as that parameter is inconsistent with the to_dense API we want, which is no parameters.

Closes #14647.

jreback changed the titleBUG: Patch to_dense behaviour for sparse. DEPR: Patch to_dense behaviour for sparse.

Nov 18, 2016

Current coverage is 85.21% (diff: 100%)

Merging #14686 into master will decrease coverage by <.01%

@@ master #14686 diff @@

Files 143 143
Lines 50796 50800 +4
Methods 0 0
Messages 0 0
Branches 0 0

• Hits 43285 43288 +3

• Misses 7511 7512 +1
  Partials 0 0

Powered by Codecov. Last update 880de30...ad7da32

Patches the following for to_dense:

1. Fix SparseArray.to_dense documentation to refer to SparseArray and not SparseSeries.

2. Deprecate the fill parameter in SparseArray.to_dense, as that parameter was not being respected.

3. Deprecate the sparse_only parameter in SparseSeries.to_dense, as that parameter is inconsistent with the to_dense API we want, which is no parameters.

Closes pandas-devgh-14647.

lgtm. tough travis is not passing.

@jreback : One of the build machines appears to have broke for a reason unrelated to this PR. Are you able to restart the build on your end?

@jreback : Everything is passing. Ready to merge if there is nothing else.

gfyoung added a commit to forking-repos/pandas that referenced this pull request

Sep 30, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request

Oct 16, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request

Oct 18, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request

Oct 18, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request

Oct 18, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.

jreback pushed a commit that referenced this pull request

Oct 18, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref gh-14686.

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request

Nov 19, 2018

Also deprecate fill in .get_values because its parameter was being passed to .to_dense, which no longer accepts the fill parameter.

xref pandas-devgh-14686.