pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Just a small thing I noticed in a footnote here. Probably can't do much about the extra classes, but rowspan/colspan seem like easy fixes to save a few bytes per row/col and it's already done in the other code path.

Don't really know if this is major enough to deserve a what's new entry.

~~closes #xxxx~~ - N/A
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

@QuLogic thanks. Could you check and see if we have any tests of colspan > 1 when there's a MultiIndex in the columns? I see we have one for rowspan > 1 with a MI in the index, but didn't see one for the columns.

I'm not sure where it is, but codecov says it's hitting both colspan > 1 and rowspan > 1.

is there any visible effect of this? You can add a whatsnew entry with this PR number just to document. Maybe under Other Enhancements. lgtm. otherwise.

Save a few bytes per row/col and it's already done in the other code path.

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request

Mar 21, 2017

Author: Elliott Sales de Andrade quantum.analyst@gmail.com

Closes pandas-dev#15403 from QuLogic/no-extra-span and squashes the following commits:

9a8fcee [Elliott Sales de Andrade] Don't add rowspan/colspan if it's 1.