pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits6 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Moving setUp from tests_dates_generator.py to function scope variable.

jaehoonhwang changed the title~~TST: move pandas/tests/io/test_date_converters.py to pandas/tests/io/parsers/parse_dates.py~~ [WIP] TST: move pandas/tests/io/test_date_converters.py to pandas/tests/io/parsers/parse_dates.py

Mar 16, 2017

tm.assert_frame_equal(result, expected)

def test_parse_date_time(self):
# From test_date_coverter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment not needed

pls remove the original file (test_date_converts.py)!

ping on green.

jreback added the Testing

pandas testing functions or related to the test suite

label

Mar 17, 2017

Import date, Multiindex and fixed self.readcsv added

from pandas import compat
from pandas.compat import parse_date, StringIO, lrange
from pandas.compat.numpy import np_array_datetime64_compat
from pandas.io.parsers import read_table

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use read_table

instead these should use self.read_csv

columns=['date_time', ('A', 'a'), ('B', 'b')])
tm.assert_frame_equal(result, expected)

def test_parse_date_time(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things that are strictly related the the actual parsing (e.g. just involve conv) can be put in a separate class; name it TestConverters (otherwise it won't be run)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually nvm about this comment

jaehoonhwang changed the title~~[WIP] TST: move pandas/tests/io/test_date_converters.py to pandas/tests/io/parsers/parse_dates.py~~ TST: move pandas/tests/io/test_date_converters.py to pandas/tests/io/parsers/parse_dates.py

Mar 20, 2017

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request

Mar 21, 2017

…parsers/parse_dates.py

closes pandas-dev#15519

Author: Jaehoon Hwang jaehoon217@gmail.com

Closes pandas-dev#15707 from jaehoonhwang/TST15519 and squashes the following commits:

0b309d3 [Jaehoon Hwang] Fixed frame email and PEP8 ef6e8fa [Jaehoon Hwang] Fixing up few lines and imports e019e95 [Jaehoon Hwang] Imported read_table and using self.readcsv 3eb63c5 [Jaehoon Hwang] TST15519 Moving Unit tests to appropriate file 9b20caa [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master' b977615 [Jaehoon Hwang] Merge remote-tracking branch 'pandas-dev/master'

mattip pushed a commit to mattip/pandas that referenced this pull request

Apr 3, 2017