DOC/API: Move Styler import by TomAugspurger · Pull Request #16059 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
From the top-level to pandas.io.formats.style.Styler, which is a bit wordy
but I was having circular-import issues at pandas.io.formats.
I think that's ok since people won't really be using this interactively.
Closes #16009
From the top-level to pandas.io.formats.style.Styler, which is a bit wordy but I was having circular-import issues at pandas.io.formats. I think that's ok since people won't really be using this interactively.
Closes pandas-dev#16009
api.rst also needs an update
In this issue (#16009), I also raised the question whether we should deprecate the old location. But is there currently a reason that a user would use the actual object instead of access it through df.style ? (if not, the deprecation is probably not needed?)
I believe api.rst was already changed as part of the move.
Style
-----
.. currentmodule:: pandas.io.formats.style
``Styler`` objects are returned by :attr:`pandas.DataFrame.style`.
For the deprecation... I could go either way. 5516aa4 adds a compatibility shim pointing to the new location. I'll add it to the master list if we decide to include it.
I believe api.rst was already changed as part of the move.
Ah yes, my bad! (I actually even said it myself #16009 (comment) :-))
@jorisvandenbossche all good for you? Is everyone OK with a deprecation warning from pandas.formats.style, to be removed in 0.21?
pcluo pushed a commit to pcluo/pandas that referenced this pull request
- DOC/API: Move Styler import
From the top-level to pandas.io.formats.style.Styler, which is a bit wordy but I was having circular-import issues at pandas.io.formats. I think that's ok since people won't really be using this interactively.
Closes pandas-dev#16009
- Added deprecation warning and shim
Labels
2 participants
