DEPR: provide deprecations and exposure for NaTType by jreback · Pull Request #16146 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Currently, under the main module privacy changes table we have

• The function union_categoricals() is now importable from pandas.api.types, formerly from pandas.types.concat (GH15998)

Do you want to add an entry for NaTTYpe is not importable from pandas.api.types?

Do you want to add an entry for NaTTYpe is not importable from pandas.api.types?
sure

@jreback Have you seen the comment of @shoyer on the issue?

The right way to use this going forward is probably type(pd.NaT). I'm not sure what the point of exposing NaTType is, given that it's a singleton. Python 2 had types.NoneType but they removed it in Python 3.

I think that makes sense, and thus it is maybe not needed to expose this publicly (we can also say to use that in the deprecation message)

if u look at the PR that's exactly what i did

it's in the deprecation message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops :-)
That's what you get from rebasing instead of adding a new commit, as there was no notification of a change, I supposed it was the original state that was merged :-)

pcluo pushed a commit to pcluo/pandas that referenced this pull request

May 22, 2017