DEPR: add shims for util + TST: test that we work in downstream packages by jreback · Pull Request #16250 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation22 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
pandas testing functions or related to the test suite
label
| "from pandas.util", |
|---|
| DeprecationWarning, stacklevel=3) |
| from pandas.util import cache_readonly # noqa |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Nice to add such test
@jreback I'm taking care of the release note for this in my doc updates (will have a PR shortly).
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
turns out our build-test build was not actually testing the correct installation :<
TomAugspurger added a commit that referenced this pull request
- DOC: Updated release notes for 0.20.1
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for #16250
DOC: Move 0.20.1 to a note
DOC: Simplify excel style example
lon it built correctly but still some issue
will investigate
This all passed. Good to merge then?
Ah, yes, I didn't look at the allowed failures...
But, it is only the setting up of the test build env, not the actual code changes? Those could already be merged?
Ah, yes I think so. Although, those tests will be skipped if the deps aren't around. Do we we have dask and geopandas anywhere else in the matrix?
we can test those two locally
I checked out this PR, and can confirm it fixed the geopandas import for me
@jreback OK to merge and fix the test later?
(I can also split off just the code changes to merge only that)
TST: test that we work in downstream packages DEPR: add shims for util + TST: test that we work in downstream packages
pcluo pushed a commit to pcluo/pandas that referenced this pull request
- DOC: Updated release notes for 0.20.1
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
DOC: Move 0.20.1 to a note
DOC: Simplify excel style example
pcluo pushed a commit to pcluo/pandas that referenced this pull request
stangirala pushed a commit to stangirala/pandas that referenced this pull request
- DOC: Updated release notes for 0.20.1
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
DOC: Move 0.20.1 to a note
DOC: Simplify excel style example
stangirala pushed a commit to stangirala/pandas that referenced this pull request
yarikoptic added a commit to neurodebian/pandas that referenced this pull request
gfyoung added a commit to forking-repos/pandas that referenced this pull request
gfyoung added a commit to forking-repos/pandas that referenced this pull request
jreback pushed a commit that referenced this pull request
Removes the following:
- pandas.types
- pandas.computation
- pandas.util.decorators
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request
Labels
Functionality to remove in pandas
pandas testing functions or related to the test suite